-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Admin depertment page styling #11853
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments related to copy.
}), | ||
}} | ||
add={{ | ||
linkProps: { | ||
href: paths.departmentCreate(), | ||
label: intl.formatMessage({ | ||
defaultMessage: "Create Department", | ||
id: "ZbpbD6", | ||
defaultMessage: "Create new department", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New is implied when creating something. Can we remove the word new?
columnHelper.accessor("departmentNumber", { | ||
id: "departmentNumber", | ||
filterFn: "weakEquals", | ||
header: intl.formatMessage({ | ||
defaultMessage: "Department #", | ||
id: "QOvS1b", | ||
defaultMessage: "Number", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everywhere else in the forms, it is referred to as Department number. Should it not be kept the same for consistency?
defaultMessage: "Search departments", | ||
id: "bUyxJi", | ||
description: "Label for the departments table search input", | ||
defaultMessage: "Search by keyword", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a keyword?
defaultMessage: 'Use the "Create Department" button to get started.', | ||
id: "yat9wx", | ||
defaultMessage: | ||
'Use the "Create new department" button to get started.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π€ Resolves #11478
π Introduction
Updates the styling of the admin department pages and adds a new "view department" page.
π΅οΈ Details
I've rolled a few more things into this one.
I reduced the bottom padding on the new hero to x2. I've refrained from making any larger changes in this PR, though.
I created a new CardSectioned component. Visually it is based on CardBasic and it is broken up like PreviewList. It's not very flexible right now because we didn't receive any designs for it. Hopefully it can become a standard component that is reused widely someday.
π§ͺ Testing
πΈ Screenshot