[Feature] Admin depertment page styling #11853
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnigh
reviewed
Oct 24, 2024
| }), | ||
| }} | ||
| add={{ | ||
| linkProps: { | ||
| href: paths.departmentCreate(), | ||
| label: intl.formatMessage({ | ||
| defaultMessage: "Create Department", | ||
| id: "ZbpbD6", | ||
| defaultMessage: "Create new department", |
There was a problem hiding this comment.
New is implied when creating something. Can we remove the word new?
| columnHelper.accessor("departmentNumber", { | ||
| id: "departmentNumber", | ||
| filterFn: "weakEquals", | ||
| header: intl.formatMessage({ | ||
| defaultMessage: "Department #", | ||
| id: "QOvS1b", | ||
| defaultMessage: "Number", |
There was a problem hiding this comment.
Everywhere else in the forms, it is referred to as Department number. Should it not be kept the same for consistency?
| defaultMessage: "Search departments", | ||
| id: "bUyxJi", | ||
| description: "Label for the departments table search input", | ||
| defaultMessage: "Search by keyword", |
| defaultMessage: 'Use the "Create Department" button to get started.', | ||
| id: "yat9wx", | ||
| defaultMessage: | ||
| 'Use the "Create new department" button to get started.', |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Resolves #11478
👋 Introduction
Updates the styling of the admin department pages and adds a new "view department" page.
🕵️ Details
I've rolled a few more things into this one.
I reduced the bottom padding on the new hero to x2. I've refrained from making any larger changes in this PR, though.
I created a new CardSectioned component. Visually it is based on CardBasic and it is broken up like PreviewList. It's not very flexible right now because we didn't receive any designs for it. Hopefully it can become a standard component that is reused widely someday.
🧪 Testing
📸 Screenshot